several issues, now fixed
-----
| Author | Message | |
|---|---|---|
|
chadriden |
||
| Wed Feb 15, 2006 6:22 pm Post subject: several issues, now fixed | ||
|
I just installed this on my forum. I'm running:
phpBB 2.0.19 php 4.3.11 I had several issues which I fixed but wanted to bring to your attention: I had the blank pop-up window problem, but fixed that thanks to the info in the sticky note. When I add buddies, they get a PM where it says "user-name has added you to his or her Buddy List." When I click on "user-name" in that PM, I get the message "user does not exist." I noticed that the url it was trying to go to was: http://www.MyUrl.com/forum//profile.php?mode=viewprofile&u=104 Several things to note there: - the // after "forum". - instead of the & symbol, twice you see "&" in the url I fixed this by: editing: /mods/contact/classconflict.php change lines 469, 470 from: Code: $base_profile_url .= '/profile.' . $phpEx . '?mode=viewprofile&sid=' . $userdata['session_id'] . '&' . POST_USERS_URL . '=';
$contactcp_string .= '/contact.' . $phpEx . '?mode=show&sid=' . $userdata['session_id']; to: Code: $base_profile_url .= '/profile.' . $phpEx . '?mode=viewprofile&sid=' . $userdata['session_id'] . '&' . POST_USERS_URL . '=';
$contactcp_string .= '/contact.' . $phpEx . '?mode=show&sid=' . $userdata['session_id']; and editing: /contact/functions_common.php change line 33 from: Code: $server['script'] .= '/';
to: Code: //$server['script'] .= '/';
in "file_edits.txt" you say: Code: #
#-----[ OPEN ]------------------------------------------ # admin/index.php # #-----[ FIND ]------------------------------------------ # default: $location = $lang['Forum_index']; $location_url = "index.$phpEx?pane=right"; # #-----[ BEFORE, ADD ]------------------------------------------ # //------------------------------------------------------------------------ // Contact List - Begin Code Addition // case PAGE_CONTACT: include_once($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_contact.' . $phpEx); $location = $lang['Contact_Management']; $location_url = "index.$phpEx?pane=right"; break; // // Contact List - End Code Addition //------------------------------------------------------------------------ # #-----[ FIND ]------------------------------------------ # default: $location = $lang['Forum_index']; $location_url = "index.$phpEx?pane=right"; # #-----[ BEFORE, ADD ]------------------------------------------ # //------------------------------------------------------------------------ // Contact List - Begin Code Addition // case PAGE_CONTACT: include_once($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_contact.' . $phpEx); $location = $lang['Contact_Management']; $location_url = "index.$phpEx?pane=right"; break; // // Contact List - End Code Addition //------------------------------------------------------------------------ ..but that seems to be the same edit listed twice. also in "file_edits.txt" you say: Code: # #-----[ OPEN ]------------------------------------------ # viewtopic.php ......... several edits removed for brevity .......... # #-----[ FIND ]------------------------------------------ # // // Parse message and/or sig for BBCode if reqd // if ( $board_config['allow_bbcode'] ) { # #-----[ AFTER, ADD ]------------------------------------------ # //------------------------------------------------------------------------ // Contact List - Begin Code Addition // check_quotes($message, $bbcode_uid, $baseurl, $contact_list, $ignore_users); // // Contact List - End Code Addition //------------------------------------------------------------------------ ..but instead of that code I found: Code: //
// Parse message and/or sig for BBCode if reqd // if ($user_sig != '' && $user_sig_bbcode_uid != '') { $user_sig = ($board_config['allow_bbcode']) ? bbencode_second_pass($user_sig, $user_sig_bbcode_uid) : preg_replace("/\:$user_sig_bbcode_uid/si", '', $user_sig); } if ($bbcode_uid != '') { $message = ($board_config['allow_bbcode']) ? bbencode_second_pass($message, $bbcode_uid) : preg_replace("/\:$bbcode_uid/si", '', $message); } if ( $user_sig != '' ) { $user_sig = make_clickable($user_sig); } $message = make_clickable($message); ..and so I added: Code: //------------------------------------------------------------------------
// Contact List - Begin Code Addition // check_quotes($message, $bbcode_uid, $baseurl, $contact_list, $ignore_users); // // Contact List - End Code Addition //------------------------------------------------------------------------ ..BEFORE that block. Everything seems to be working just fine for me now.. except.. I've done a mod to how my PM's work. See: http://www.phpbbhacks.com/download/2214 ..this basically sends the user name and body of a PM in the notification email. While I was at it, I fixed my board so it sends the subject line and a note about how they can block and ignore users using your cool mod. Because of that, I notice that the "system" PM's that your mod sends out (telling people "so and so just added you as a buddy") - come thru the with a blank sender, subject and message when the notification is sent out. I haven't figured this one out yet. All in all, this is a great mod and I just wanted to thank you for all of your efforts. |
||
|
Thoul |
||
| Thu Feb 16, 2006 8:29 am Post subject: re: several issues, now fixed | ||
|
Thanks for the notes.
The edits for admin/index.php are correct, actually. If you look closely at the FIND codes, you'll see that each FIND block has different spacing at the beginning of the line. The same stuff is in admin/index.php twice, too. The viewtopic.php differences are due to a change in a release of phpBB after the last release of the mod. I'll update that instruction and fix some of the other issues in the next release (hopefully soon). I'll have to look at the email notification thing pretty closely myself. This is the first time I've been told of anyone having a problem with that. |
||
Page 1 of 1